Repository navigation
[PWGJE] Add Vx, Vy, Vz columns to aod::JMcParticles - #18783
choich08365 wants to merge 2 commits into
Conversation
|
O2 linter results: ❌ 0 errors, |
nzardosh
left a comment
There was a problem hiding this comment.
Hi Changhwan, thanks for the PR. For these PRs that really impact the core framework please discuss them before making them in the future. I am not sure if this information should really go into the McParticles table or in a separate one thats joinable but we can keep it here for now and then see
| { | ||
| precisionPositionMask = 0xFFFFFC00; // 13 bits | ||
| precisionMomentumMask = 0xFFFFFC00; // 13 bits this is currently keept at 13 bits wihich gives roughly a resolution of 1/8000. This can be increased to 15 bits if really needed | ||
| precisionVertexMask = 0xFFFFFC00; // 13 bits tentative value |
There was a problem hiding this comment.
I think you can use the precisionPositionMask since this is a positional variable
| for (const auto& particle : particlesPerMcCollision) { | ||
| // Assign output indices only to particles that will actually be stored. | ||
| if (!config.savePartonLevelInfo && !particle.isPhysicalPrimary()) { | ||
| continue; |
There was a problem hiding this comment.
why is this added here? Does it hurt to have the full mapping?
There was a problem hiding this comment.
Hi @nzardosh, I'm sorry for making a PR without any discussion with you.
The particleMapping vector provides processTracksMcParticleLabel() with the output particle indices assigned by processMcParticles(). When config.savePartonLevelInfo == false, only physical primary particles are stored in StoredJMcParticles table. If the mapping assigns indices to all particles, skipping non-physical primary particles during storage causes the mapped indices to differ from the actual output row indices, resulting in incorrect MC particle references in the stored track labels.
Add MC particle production vertex coordinates to the JE derived data model so that GNN vertex labeling can run without the original
aod::McParticlestable.Also fix a bug in particle index remapping when
config.savePartonLevelInfo == false.PWGJE/DataModel/JetReducedData.hVx,Vy, andVzcolumns for MC particle production vertex coordinates toaod::JMcParticles. The staged declaration also includes these columns inaod::StoredJMcParticles.PWGJE/TableProducer/derivedDataProducer.cxx,PWGJE/TableProducer/derivedDataProducerEmbedding.cxxPWGJE/TableProducer/derivedDataWriter.cxxconfig.savePartonLevelInfo == falseby assigning output indices only to particles that are actually stored.PWGJE/Core/JetTaggingUtilities.hvertexClustering()to read production vertex coordinates directly fromaod::JMcParticlestable and remove its originalaod::McParticlestable argument.PWGJE/TableProducer/jetGnnDefinition.cxxaod::McParticlesinput and update thevertexClustering()call accordingly.